Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14_0_X] Fix metMCTable in NanoGEN #44851

Merged
merged 1 commit into from
Apr 26, 2024
Merged

[14_0_X] Fix metMCTable in NanoGEN #44851

merged 1 commit into from
Apr 26, 2024

Conversation

hqucms
Copy link
Contributor

@hqucms hqucms commented Apr 25, 2024

backport of #44850

PR description:

Fixes the ProductNotFound error in relval wf 546.0, as reported in #44782 (comment).

Cause of the error: In we changed metMCTable to take input of the specific pat::MET type. However, in the NanoGEN customization, the input is changed to genMetTrue which is of a different type (reco::MET), thus the ProductNotFound error.

PR validation:

runTheMatrix.py -l 546.0,547.0,548.0 --ibeos

@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Apr 25, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 25, 2024 •
edited
Loading

A new Pull Request was created by @hqucms for CMSSW_14_0_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@hqucms, @cmsbuild, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 25, 2024 •
edited
Loading

cms-bot internal usage

@hqucms hqucms mentioned this pull request Apr 25, 2024
Merged
@hqucms
Copy link
Contributor Author

hqucms commented Apr 25, 2024

enable nano

@hqucms
Copy link
Contributor Author

hqucms commented Apr 25, 2024

please test workflow 546.0,547.0,548.0

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c9d27c/39105/summary.html
COMMIT: d5381b2
CMSSW: CMSSW_14_0_X_2024-04-25-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44851/39105/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 14 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 49 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3326485
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3326453
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 210 log files, 173 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 17023
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 17023
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 49 log files, 29 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.783 2.783 0.000 ( +0.0% ) 3.94 3.99 -1.1% 2.241 2.140
2500.001 2.897 2.897 0.000 ( +0.0% ) 3.55 3.54 +0.3% 2.578 2.536
2500.002 2.843 2.843 0.000 ( +0.0% ) 3.64 3.68 -0.9% 2.579 2.518
2500.01 1.446 1.446 0.000 ( +0.0% ) 6.70 6.82 -1.7% 2.242 2.215
2500.011 1.906 1.906 0.000 ( +0.0% ) 3.60 3.63 -0.7% 2.382 2.374
2500.012 1.761 1.761 0.000 ( +0.0% ) 5.29 5.36 -1.4% 2.368 2.308
2500.1 2.354 2.354 0.000 ( +0.0% ) 5.07 5.13 -1.2% 2.012 1.986
2500.2 2.459 2.459 0.000 ( +0.0% ) 5.90 5.95 -0.9% 1.908 1.888
2500.21 1.286 1.286 0.000 ( +0.0% ) 4.22 4.24 -0.5% 2.233 2.169
2500.211 1.668 1.668 0.000 ( +0.0% ) 3.77 3.87 -2.6% 2.210 2.205
2500.3 2.229 2.229 0.000 ( +0.0% ) 11.57 12.14 -4.7% 1.981 1.874
2500.301 2.833 2.833 0.000 ( +0.0% ) 10.57 10.68 -1.0% 1.964 1.828
2500.31 1.348 1.348 0.000 ( +0.0% ) 18.94 19.69 -3.8% 2.378 2.248
2500.311 1.757 1.757 0.000 ( +0.0% ) 15.14 15.10 +0.3% 2.328 2.288
2500.312 7.164 7.164 0.000 ( +0.0% ) 1.54 1.58 -2.6% 1.694 1.697
2500.313 1.568 1.568 0.000 ( +0.0% ) 7.88 9.30 -15.2% 1.050 1.045
2500.314 1.236 1.236 0.000 ( +0.0% ) 13.98 14.96 -6.6% 2.213 2.235
2500.315 1.874 1.874 0.000 ( +0.0% ) 14.71 15.57 -5.5% 2.339 2.348
2500.316 3.342 3.342 0.000 ( +0.0% ) 2.03 2.06 -1.4% 2.216 2.135
2500.317 1.811 1.811 0.000 ( +0.0% ) 13.79 14.74 -6.5% 2.146 2.135
2500.318 4.136 4.136 0.000 ( +0.0% ) 5.60 5.80 -3.4% 2.159 2.135
2500.4 2.374 2.374 0.000 ( +0.0% ) 11.54 12.08 -4.5% 1.907 1.901
2500.401 1.885 1.885 0.000 ( +0.0% ) 9.88 10.49 -5.8% 1.689 1.701
2500.402 2.950 2.950 0.000 ( +0.0% ) 9.92 10.55 -5.9% 1.704 1.720
2500.403 5.474 5.474 0.000 ( +0.0% ) 1.43 1.47 -2.7% 1.803 1.759
2500.404 2.860 2.860 0.000 ( +0.0% ) 9.71 10.41 -6.7% 1.772 1.713
2500.405 8.700 8.700 0.000 ( +0.0% ) 3.54 3.67 -3.5% 1.888 1.894
2500.5 5.194 5.194 0.000 ( +0.0% ) 15.76 16.36 -3.6% 1.555 1.506
2500.51 9.120 9.120 0.000 ( +0.0% ) 9.81 9.85 -0.3% 1.616 1.495

@hqucms
Copy link
Contributor Author

hqucms commented Apr 25, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e5f9f46 into cms-sw:CMSSW_14_0_X Apr 26, 2024
12 checks passed
@antoniovilela antoniovilela mentioned this pull request Apr 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok fully-signed orp-approved tests-approved xpog-approved
Projects
None yet
Milestone
CMSSW_14_0_X
Development

Successfully merging this pull request may close these issues.
3 participants
@hqucms @cmsbuild @antoniovilela